Permalink
Browse files

All: Drop support for IE7

Fixes #9838
Closes gh-1365
  • Loading branch information...
1 parent faf87d9 commit 6d7589351eae1e180579fc0c87885e5ab7a73f48 @scottgonzalez scottgonzalez committed Oct 20, 2014
@@ -14,10 +14,6 @@
padding: 4px;
display: inline-block;
}
- /* support: IE7 */
- *+html #toolbar {
- display: inline;
- }
</style>
<script>
$(function() {
@@ -35,10 +35,6 @@
font-size: 12px;
line-height: 15px;
}
- /* avoid IE7 oscillating between overflow visible and scroll values */
- #list1 > div {
- overflow: visible;
- }
</style>
</head>
<body>
@@ -193,7 +193,8 @@ test("open", function() {
ok(element.dialog("widget").is(":visible") && !element.dialog("widget").is(":hidden"), "dialog visible after open method called");
});
-test("#6137: dialog('open') causes form elements to reset on IE7", function() {
+// http://bugs.jqueryui.com/ticket/6137
+test("Ensure form elements don't reset when opening a dialog", function() {
expect(2);
var d1 = $("<form><input type='radio' name='radio' id='a' value='a' checked='checked'></input>" +
@@ -371,9 +371,9 @@ test("minWidth", function() {
test( "position, default center on window", function() {
expect( 2 );
- // dialogs alter the window width and height in FF and IE7
+ // dialogs alter the window width and height in Firefox
// so we collect that information before creating the dialog
- // Support: FF, IE7
+ // Support: Firefox
var winWidth = $( window ).width(),
winHeight = $( window ).height(),
element = $("<div></div>").dialog(),
@@ -387,9 +387,9 @@ test( "position, default center on window", function() {
test( "position, right bottom at right bottom via ui.position args", function() {
expect( 2 );
- // dialogs alter the window width and height in FF and IE7
+ // dialogs alter the window width and height in Firefox
// so we collect that information before creating the dialog
- // Support: FF, IE7
+ // Support: Firefox
var winWidth = $( window ).width(),
winHeight = $( window ).height(),
element = $("<div></div>").dialog({
@@ -35,10 +35,6 @@
}
.ui-menu .ui-menu-item {
padding: 0;
- /* Support: IE7 */
- *display: block;
- *float: left;
- *clear: left;
}
#menu3 {
height: 250px;
@@ -49,12 +49,9 @@ test( "mousedown: initial position of helper", function() {
clientY: 10
});
- // we do a GTE comparison here because IE7 erroneously subtracts
- // 2 pixels from a simulated mousedown for clientX/Y
- // Support: IE7
helperOffset = $( ".ui-selectable-helper" ).offset();
- ok( helperOffset.top >= 99, "Scroll top should be accounted for." );
- ok( helperOffset.left >= 99, "Scroll left should be accounted for." );
+ ok( helperOffset.top, 110, "Scroll top should be accounted for." );
+ ok( helperOffset.left, 110, "Scroll left should be accounted for." );
// Cleanup
element.simulate( "mouseup" );
@@ -14,7 +14,6 @@
position: relative;
margin: 2px 0 0 0;
padding: .5em .5em .5em .7em;
- min-height: 0; /* support: IE7 */
font-size: 100%;
}
.ui-accordion .ui-accordion-icons {
@@ -43,9 +43,6 @@
.ui-helper-clearfix:after {
clear: both;
}
-.ui-helper-clearfix {
- min-height: 0; /* support: IE7 */
-}
.ui-helper-zfix {
width: 100%;
height: 100%;
@@ -23,7 +23,6 @@
margin: 0;
padding: 3px 1em 3px .4em;
cursor: pointer;
- min-height: 0; /* support: IE7 */
/* support: IE10, see #8844 */
list-style-image: url("data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7");
}
@@ -18,8 +18,6 @@
}
.ui-selectmenu-menu .ui-menu {
overflow: auto;
- /* Support: IE7 */
- overflow-x: hidden;
@fnagel
fnagel Nov 3, 2014 Member

@scottgonzalez It seems this comment was no longer valid as the overflow-x seems needed for FF and Chrome too. Perhaps due to markup changes?

@scottgonzalez
scottgonzalez Nov 4, 2014 Member

Can you show what's broken?

@fnagel
fnagel Nov 4, 2014 Member

There's a scrollbar which isn't supposed to be there.
screenshot 1

@scottgonzalez
scottgonzalez Nov 4, 2014 Member

Thanks. Those are hard to notice on OS X since the scrollbars are hidden. Fixed in e648447.

padding-bottom: 1px;
}
.ui-selectmenu-menu .ui-menu .ui-selectmenu-optgroup {
View
@@ -48,10 +48,6 @@ return $.widget( "ui.tabs", {
return function( anchor ) {
var anchorUrl, locationUrl;
- // support: IE7
- // IE7 doesn't normalize the href property when set via script (#9317)
- anchor = anchor.cloneNode( false );
-
anchorUrl = anchor.href.replace( rhash, "" );
locationUrl = location.href.replace( rhash, "" );

0 comments on commit 6d75893

Please sign in to comment.