Permalink
Browse files

Fixes #6979 - Several components are leaking variables into the globa…

…l scope.
  • Loading branch information...
1 parent c45911c commit 6fb584e7007bb7dc539d9c7266d17833c52a7830 @felix9 felix9 committed with scottgonzalez Mar 29, 2012
@@ -419,7 +419,7 @@ $.extend($.effects, {
setTransition: function(element, list, factor, value) {
value = value || {};
$.each(list, function(i, x){
- unit = element.cssUnit(x);
+ var unit = element.cssUnit(x);
if (unit[0] > 0) value[x] = unit[0] * factor + unit[1];
});
return value;
@@ -15,8 +15,8 @@
$.effects.pulsate = function(o) {
return this.queue(function() {
var elem = $(this),
- mode = $.effects.setMode(elem, o.options.mode || 'show');
- times = ((o.options.times || 5) * 2) - 1;
+ mode = $.effects.setMode(elem, o.options.mode || 'show'),
+ times = ((o.options.times || 5) * 2) - 1,
duration = o.duration ? o.duration / 2 : $.fx.speeds._default / 2,
isVisible = elem.is(':visible'),
animateTo = 0;
@@ -140,7 +140,7 @@ $.effects.size = function(o) {
hProps = hProps.concat(['marginLeft','marginRight']); // Add margins
props2 = props.concat(vProps).concat(hProps); // Concat
el.find("*[width]").each(function(){
- child = $(this);
+ var child = $(this);
if (restore) $.effects.save(child, props2);
var c_original = {height: child.height(), width: child.width()}; // Save original
child.from = {height: c_original.height * factor.from.y, width: c_original.width * factor.from.x};
@@ -594,7 +594,7 @@ $.widget("ui.menu", {
}
var base = this.active.offset().top,
- height = this.element.height();
+ height = this.element.height(),
result = this.element.children(".ui-menu-item").filter(function() {
var close = $(this).offset().top - base + height - $(this).height();
// TODO improve approximation
@@ -733,7 +733,6 @@ $.extend( $.ui.tabs.prototype, {
}
}
: function( e ) {
- t = o.selected;
rotate();
});

0 comments on commit 6fb584e

Please sign in to comment.