Skip to content
Permalink
Browse files

Build: Remove grunt concat task its no longer used

This task was only used to create the combined js file for sizer
and for creating the combined files for the NPM package. The
npm package is no longer maintained so there is no need for this any more.
  • Loading branch information
arschmitz committed Aug 3, 2015
1 parent a486903 commit 7cb0a2ba890e6a5c921d74e1c563b57359419311
Showing with 0 additions and 42 deletions.
  1. +0 −42 Gruntfile.js
@@ -24,29 +24,6 @@ var

allI18nFiles = expandFiles( "ui/i18n/*.js" ),

cssFiles = [
"core",
"accordion",
"autocomplete",
"button",
"datepicker",
"dialog",
"draggable",
"menu",
"progressbar",
"resizable",
"selectable",
"selectmenu",
"sortable",
"slider",
"spinner",
"tabs",
"tooltip",
"theme"
].map(function( component ) {
return "themes/base/" + component + ".css";
}),

// minified files
minify = {
options: {
@@ -149,25 +126,6 @@ grunt.initConfig({
dist: "<%= pkg.name %>-<%= pkg.version %>"
},
compare_size: compareFiles,
concat: {
i18n: {
options: {
banner: createBanner( allI18nFiles )
},
src: allI18nFiles,
dest: "dist/i18n/jquery-ui-i18n.js"
},
css: {
options: {
banner: createBanner( cssFiles ),
stripBanners: {
block: true
}
},
src: cssFiles,
dest: "dist/jquery-ui.css"
}
},
requirejs: {
js: {
options: {

5 comments on commit 7cb0a2b

@chrishiebert

This comment has been minimized.

Copy link

chrishiebert replied Sep 16, 2015

Reference to Grunt concat task left in jquery-ui/README.md

The grunt concat task was removed from Gruntfile.js, however the "Building jQuery UI" section of the README.md still references the task.

Readme file:
[https://github.com/jquery/jquery-ui/blob/master/README.md]

Commit removing the task:
[https://github.com/jquery/jquery-ui/commit/7cb0a2ba890e6a5c921d74e1c563b57359419311]

Attempted to submit a bug report.

Trac Error
Submission rejected as potential spam (Maximum number of posts per hour for this IP (127.0.0.1) exceeded)

@scottgonzalez

This comment has been minimized.

Copy link
Member

scottgonzalez replied Sep 16, 2015

@chrishiebert Thanks, I've removed that section since it's no longer relevant.

@jzaefferer

This comment has been minimized.

Copy link
Member

jzaefferer replied Sep 17, 2015

Guess what else we missed! This was used by Jenkins to upload git builds to the CDN. Accordingly those builds haven been broken since: http://jenkins.jquery.com/job/jQuery%20UI/

@jzaefferer

This comment has been minimized.

Copy link
Member

jzaefferer replied Sep 17, 2015

Which I think we can replace with the new requirejs task. Trying that...

@jzaefferer

This comment has been minimized.

Copy link
Member

jzaefferer replied Sep 17, 2015

That fixes the build (which doesn't look too bad either: http://swarm.jquery.org/job/1295 ), but we still lost dist/jquery-ui.css.

Please sign in to comment.
You can’t perform that action at this time.