Skip to content
Permalink
Browse files

Dialog: Have _createButtons access the buttons option directly. Start…

… refactoring _setOption, no need for switch.
  • Loading branch information...
jzaefferer committed Nov 15, 2012
1 parent fed2972 commit 7e964be80c415373be4d204bf444dc12648974c5
Showing with 8 additions and 6 deletions.
  1. +8 −6 ui/jquery.ui.dialog.js
@@ -191,7 +191,7 @@ $.widget("ui.dialog", {
}

// TODO merge with _createButtonPane?
this._createButtons( options.buttons );
this._createButtons();

this._isOpen = false;

@@ -362,8 +362,9 @@ $.widget("ui.dialog", {
this._delay( checkFocus );
},

_createButtons: function( buttons ) {
var that = this;
_createButtons: function() {
var that = this,
buttons = this.options.buttons;

// if we already have a button pane, remove it
this.uiDialogButtonPane.remove();
@@ -573,10 +574,11 @@ $.widget("ui.dialog", {

this._super( key, value );

if ( key === "buttons" ) {
this._createButtons();
}

switch ( key ) {
case "buttons":
this._createButtons( value );
break;
case "closeText":
// ensure that we always pass a string
this.uiDialogTitlebarClose.button({

0 comments on commit 7e964be

Please sign in to comment.
You can’t perform that action at this time.