From 8959057ecced5287d94d1edd219ec00cf4117ef8 Mon Sep 17 00:00:00 2001 From: jzaefferer Date: Thu, 28 Oct 2010 19:22:57 +0200 Subject: [PATCH] Menu: Further refactoring of next/previousPage --- ui/jquery.ui.menu.js | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/ui/jquery.ui.menu.js b/ui/jquery.ui.menu.js index 58127566d56..a67bc34bfd2 100644 --- a/ui/jquery.ui.menu.js +++ b/ui/jquery.ui.menu.js @@ -192,18 +192,14 @@ $.widget("ui.menu", { height = this.element.height(), result; this.active.nextAll( ".ui-menu-item" ).each( function() { - var close = $( this ).offset().top - base - height; - if (close >= 0) { - result = $( this ); - return false; - } + result = $( this ); + return $( this ).offset().top - base - height < 0; }); - this.activate( event, result || this.element.children( ".ui-menu-item" ).last() ); + this.activate( event, result ); } else { this.activate( event, this.element.children( ".ui-menu-item" ) - // TODO use .first()/.last() - .filter( !this.active || this.last() ? ":first" : ":last" ) ); + [ !this.active || this.last() ? "first" : "last" ]() ); } }, @@ -219,18 +215,14 @@ $.widget("ui.menu", { height = this.element.height(), result; this.active.prevAll( ".ui-menu-item" ).each( function() { - var close = $(this).offset().top - base + height; - if (close <= 0) { - result = $( this ); - return false; - } + result = $( this ); + return $(this).offset().top - base + height > 0; }); - this.activate( event, result || this.element.children( ".ui-menu-item" ).first() ); + this.activate( event, result ); } else { this.activate( event, this.element.children( ".ui-menu-item" ) - // TODO use .first()/.last() - .filter( !this.active || this.first() ? ":last" : ":first" ) ); + [ !this.active || this.first() ? ":last" : ":first" ]() ); } },