Skip to content
Permalink
Browse files

Effect: Make .transfer() callback optional

Adds two tests to at least check that no exception is thrown.

Fixes #12223
Closes gh-1545
  • Loading branch information...
jzaefferer committed Apr 22, 2015
1 parent 897a238 commit 8b89f8c59bacb1261639c909ee60fe3b856b36e4
Showing with 29 additions and 1 deletion.
  1. +26 −0 tests/unit/effects/core.js
  2. +3 −1 ui/effect.js
@@ -258,6 +258,32 @@ test( "createPlaceholder: preserves layout affecting properties", function() {
deepEqual( before.outerHeight, placeholder.outerHeight( true ), "height preserved" );
});

module( "transfer" );

asyncTest( "transfer() without callback", function() {
expect( 0 );

// Verify that the effect works without a callback
$( "#elem" ).transfer( {
to: ".animateClass",
duration: 1
} );
setTimeout( function() {
start();
}, 25 );
} );

asyncTest( "transfer() with callback", function() {
expect( 1 );
$( "#elem" ).transfer( {
to: ".animateClass",
duration: 1
}, function() {
ok( true, "callback invoked" );
start();
} );
} );

$.each( $.effects.effect, function( effect ) {
module( "effects." + effect );

@@ -1505,7 +1505,9 @@ $.fn.extend({
})
.animate( animation, options.duration, options.easing, function() {
transfer.remove();
done();
if ( $.isFunction( done ) ) {
done();
}
});
}
});

0 comments on commit 8b89f8c

Please sign in to comment.
You can’t perform that action at this time.