Permalink
Browse files

Sortable: Moved change of helper position css. Fixed #5321 – Helper i…

…n a bottom-positioned Sortable is positioned wrong on drag start.

(cherry picked from commit 32f356b)
1 parent 6a665a1 commit 8e899dab6cd1fc410bbda0e7c88cdf1a1c8e9764 @martinf55 martinf55 committed with scottgonzalez May 7, 2012
Showing with 5 additions and 5 deletions.
  1. +5 −5 ui/jquery.ui.sortable.js
View
@@ -155,11 +155,6 @@ $.widget("ui.sortable", $.ui.mouse, {
left: this.offset.left - this.margins.left
};
- // Only after we got the offset, we can change the helper's position to absolute
- // TODO: Still need to figure out a way to make relative sorting possible
- this.helper.css("position", "absolute");
- this.cssPosition = this.helper.css("position");
-
$.extend(this.offset, {
click: { //Where the click happened, relative to the element
left: event.pageX - this.offset.left,
@@ -169,6 +164,11 @@ $.widget("ui.sortable", $.ui.mouse, {
relative: this._getRelativeOffset() //This is a relative to absolute position minus the actual position calculation - only used for relative positioned helper
});
+ // Only after we got the offset, we can change the helper's position to absolute
+ // TODO: Still need to figure out a way to make relative sorting possible
+ this.helper.css("position", "absolute");
+ this.cssPosition = this.helper.css("position");
+
//Generate the original position
this.originalPosition = this._generatePosition(event);
this.originalPageX = event.pageX;

0 comments on commit 8e899da

Please sign in to comment.