Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Autocomplete: Respect the disabled option. Fixes #5619 - Autocomplete…

… widget keeps looking for remote data even when it's disabled.
  • Loading branch information...
commit 90caa93a9b4b9b894b055cfb8dae0661ac7788b0 1 parent 58ae7ce
@scottgonzalez scottgonzalez authored
View
18 tests/unit/autocomplete/autocomplete_options.js
@@ -116,6 +116,24 @@ test("delay", function() {
}, 100);
});
+test("disabled", function() {
+ var ac = $("#autocomplete").autocomplete({
+ source: data,
+ delay: 0,
+ disabled: true
+ });
+ ac.val("ja").keydown();
+
+ same( $(".ui-menu:visible").length, 0 );
+
+ stop();
+ setTimeout(function() {
+ same( $(".ui-menu:visible").length, 0 );
+ ac.autocomplete("destroy");
+ start();
+ }, 50);
+});
+
test("minLength", function() {
var ac = $("#autocomplete").autocomplete({
source: data
View
12 ui/jquery.ui.autocomplete.js
@@ -39,6 +39,10 @@ $.widget( "ui.autocomplete", {
"aria-haspopup": "true"
})
.bind( "keydown.autocomplete", function( event ) {
+ if ( self.options.disabled ) {
+ return;
+ }
+
var keyCode = $.ui.keyCode;
switch( event.keyCode ) {
case keyCode.PAGE_UP:
@@ -88,10 +92,18 @@ $.widget( "ui.autocomplete", {
}
})
.bind( "focus.autocomplete", function() {
+ if ( self.options.disabled ) {
+ return;
+ }
+
self.selectedItem = null;
self.previous = self.element.val();
})
.bind( "blur.autocomplete", function( event ) {
+ if ( self.options.disabled ) {
+ return;
+ }
+
clearTimeout( self.searching );
// clicks on the menu (or a button to trigger a search) will cause a blur event
self.closing = setTimeout(function() {
Please sign in to comment.
Something went wrong with that request. Please try again.