Skip to content
Permalink
Browse files

Tests: Accept a small difference of animated width/height

jQuery 3.2 & newer have a different animation logic and the animated elements
width/height differ from the starting ones even at the beginning of the
animation. The point of the assertions checking that they're identical was
to ensure bug #5245 is fixed; that issue manifested by a big jump to half the
element size. To test for that, it's enough to check that the first obtained
values are close to the original ones.

This makes effects tests pass in all supported jQuery versions.

Closes gh-1928
Ref #5245
  • Loading branch information
mgol committed Jul 23, 2020
1 parent b8ec78a commit 91037d66b0ea8dd7db0b6083721d0d1b2106cd16
Showing with 4 additions and 2 deletions.
  1. +4 −2 tests/unit/effects/core.js
@@ -378,8 +378,10 @@ $.each( $.effects.effect, function( effect ) {
assert.equal( test[ 0 ].style.height, cssHeight, "Inline CSS Height has been rest after animation ended" );
ready();
} );
assert.equal( test.width(), width, "Width is the same px after animation started" );
assert.equal( test.height(), height, "Height is the same px after animation started" );
assert.ok( Math.abs( test.width() - width ) / width < 0.05,
"Width is close to the value when animation started" );
assert.ok( Math.abs( test.height() - height ) / height < 0.05,
"Height is close to the value when animation started" );
} );
} );

0 comments on commit 91037d6

Please sign in to comment.
You can’t perform that action at this time.