Tabs: When adding a new tab with an existing panel, don't move it. Fi…

…xes #4578 - adding tab moves targeted panel.
jquery · May 16, 2011 · 965cb7359ea704715839e3c171ae751d6a32dde9 · 965cb73
1 parent db3d194
commit 965cb7359ea704715839e3c171ae751d6a32dde9
Unified Split

Showing with 13 additions and 3 deletions.

+13 −3 ui/jquery.ui.tabs.js
diff --git a/ui/jquery.ui.tabs.js b/ui/jquery.ui.tabs.js
@@ -775,20 +775,30 @@ if ( $.uiBackCompat !== false ) {
 			li.addClass( "ui-state-default ui-corner-top" ).data( "destroy.tabs", true );
 			li.find( "a" ).attr( "aria-controls", id );
+  
+			var doInsertAfter = index >= this.lis.length;
+  
+
 			// try to find an existing element before creating a new one
 			var panel = this.element.find( "#" + id );
 			if ( !panel.length ) {
 				panel = this._createPanel( id );
+  
+				if ( doInsertAfter ) {
+  
+					if ( index > 0 ) {
+  
+						panel.insertAfter( this.panels.eq( -1 ) );
+  
+					} else {
+  
+						panel.appendTo( this.element );
+  
+					}
+  
+				} else {
+  
+					panel.insertBefore( this.panels[ index ] );
+  
+				}
 			}
 			panel.addClass( "ui-tabs-panel ui-widget-content ui-corner-bottom" ).hide();
-  
-			if ( index >= this.lis.length ) {
+  
+			if ( doInsertAfter ) {
 				li.appendTo( this.list );
-  
-				panel.appendTo( this.list[ 0 ].parentNode );
 			} else {
 				li.insertBefore( this.lis[ index ] );
-  
-				panel.insertBefore( this.panels[ index ] );
 			}
+  
+
 			options.disabled = $.map( options.disabled, function( n ) {
 				return n >= index ? ++n : n;
 			});