Skip to content
Permalink
Browse files

Tooltip: Check if event exists before checking properties in open(). …

…Fixes #8626 - Programatically opening a tooltip with out giving an event results in a javascript error.
  • Loading branch information...
scottgonzalez committed Oct 5, 2012
1 parent f417a92 commit 96f2aa4c72b5f29782b0736ed95468e50d338d6e
Showing with 18 additions and 1 deletion.
  1. +17 −0 tests/unit/tooltip/tooltip_methods.js
  2. +1 −1 ui/jquery.ui.tooltip.js
@@ -29,6 +29,23 @@ test( "open/close", function() {
$.fx.off = false;
});

// #8626 - Calling open() without an event
test( "open/close with tracking", function() {
expect( 3 );
$.fx.off = true;
var tooltip,
element = $( "#tooltipped1" ).tooltip({ track: true });
equal( $( ".ui-tooltip" ).length, 0, "no tooltip on init" );

element.tooltip( "open" );
tooltip = $( "#" + element.data( "ui-tooltip-id" ) );
ok( tooltip.is( ":visible" ) );

element.tooltip( "close" );
ok( tooltip.is( ":hidden" ) );
$.fx.off = false;
});

test( "enable/disable", function() {
expect( 7 );
$.fx.off = true;
@@ -216,7 +216,7 @@ $.widget( "ui.tooltip", {
positionOption.of = event;
tooltip.position( positionOption );
}
if ( this.options.track && /^mouse/.test( event.originalEvent.type ) ) {
if ( this.options.track && event && /^mouse/.test( event.originalEvent.type ) ) {
positionOption = $.extend( {}, this.options.position );
this._on( this.document, {
mousemove: position

0 comments on commit 96f2aa4

Please sign in to comment.
You can’t perform that action at this time.