Skip to content
Permalink
Browse files

mouse: events and default actions on click are not fired after a drag…

… action has been initiated
  • Loading branch information
Paul Bakaus
Paul Bakaus committed Nov 3, 2008
1 parent 77d2c66 commit 9be9c9f699611f18a229efca381ec223a8bd14ec
Showing with 17 additions and 3 deletions.
  1. +6 −0 tests/draggable.js
  2. +11 −3 ui/ui.core.js
@@ -628,6 +628,12 @@ test("{ helper: 'clone' }, absolute with scroll offset on root and parent", func

});

module("draggable: behaviour");

test("Events should not be executed on the element if drag is initiated", function() {
//TODO: Implement missing test
});


module("draggable: Tickets");

@@ -345,9 +345,16 @@ $.ui.mouse = {
_mouseInit: function() {
var self = this;

this.element.bind('mousedown.'+this.widgetName, function(e) {
return self._mouseDown(e);
});
this.element
.bind('mousedown.'+this.widgetName, function(e) {
return self._mouseDown(e);
})
.bind('click.'+this.widgetName, function(e) {
if(self._preventClickEvent) {
self._preventClickEvent = false;
return false;
}
});

// Prevent text selection in IE
if ($.browser.msie) {
@@ -437,6 +444,7 @@ $.ui.mouse = {

if (this._mouseStarted) {
this._mouseStarted = false;
this._preventClickEvent = true;
this._mouseStop(e);
}

0 comments on commit 9be9c9f

Please sign in to comment.
You can’t perform that action at this time.