Skip to content
Permalink
Browse files

Dialog: Style updates

Ref #14246
Ref gh-1588
  • Loading branch information
arschmitz committed Aug 21, 2015
1 parent f75c876 commit 9ef84a6bf0a4a1d9df62a4427d0e826d91d1606b
@@ -36,7 +36,7 @@ common.testWidget( "dialog", {
title: null,
width: 300,

// callbacks
// Callbacks
beforeClose: null,
close: null,
create: null,
@@ -35,7 +35,7 @@ common.testWidget( "dialog", {
title: null,
width: 300,

// callbacks
// Callbacks
beforeClose: null,
close: null,
create: null,
@@ -224,7 +224,7 @@ asyncTest( "Prevent tabbing out of dialogs", function() {
function checkTab() {
equal( document.activeElement, inputs[ 0 ], "Tab key event moved focus within the modal" );

// check shift tab
// Check shift tab
$( document.activeElement ).simulate( "keydown", { keyCode: $.ui.keyCode.TAB, shiftKey: true });
setTimeout( checkShiftTab );
}
@@ -76,7 +76,7 @@ test( "focus", function() {
other.dialog( "moveToTop" );
element.trigger( "mousedown" );

// triggers just once when already on top
// Triggers just once when already on top
element.dialog( "open" );
element.dialog( "moveToTop" );
element.trigger( "mousedown" );
@@ -344,7 +344,7 @@ test("minWidth", function( assert ) {
test( "position, default center on window", function( assert ) {
expect( 2 );

// dialogs alter the window width and height in Firefox
// Dialogs alter the window width and height in Firefox
// so we collect that information before creating the dialog
// Support: Firefox
var winWidth = $( window ).width(),
@@ -360,7 +360,7 @@ test( "position, default center on window", function( assert ) {
test( "position, right bottom at right bottom via ui.position args", function( assert ) {
expect( 2 );

// dialogs alter the window width and height in Firefox
// Dialogs alter the window width and height in Firefox
// so we collect that information before creating the dialog
// Support: Firefox
var winWidth = $( window ).width(),
@@ -469,7 +469,7 @@ test( "title", function() {
equal( titleText(), "foo", "title after init" );
element.remove();

// make sure attroperties are properly ignored - #5742 - .attr() might return a DOMElement
// Make sure attroperties are properly ignored - #5742 - .attr() might return a DOMElement
element = $( "<form><input name='title'></form>" ).dialog();
// some browsers return a non-breaking space and some return "&nbsp;"
// so we get the text to normalize to the actual non-breaking space
@@ -81,7 +81,7 @@ $.widget( "ui.dialog", {
title: null,
width: 300,

// callbacks
// Callbacks
beforeClose: null,
close: null,
drag: null,
@@ -353,7 +353,7 @@ $.widget( "ui.dialog", {
return;
}

// prevent tabbing out of dialogs
// Prevent tabbing out of dialogs
if ( event.keyCode !== $.ui.keyCode.TAB || event.isDefaultPrevented() ) {
return;
}
@@ -408,7 +408,7 @@ $.widget( "ui.dialog", {
}
} );

// support: IE
// Support: IE
// Use type="button" to prevent enter keypresses in textboxes from closing the
// dialog in IE (#9312)
this.uiDialogTitlebarClose = $( "<button type='button'></button>" )
@@ -464,7 +464,7 @@ $.widget( "ui.dialog", {
var that = this,
buttons = this.options.buttons;

// if we already have a button pane, remove it
// If we already have a button pane, remove it
this.uiDialogButtonPane.remove();
this.uiButtonSet.empty();

@@ -722,12 +722,12 @@ $.widget( "ui.dialog", {
uiDialog.resizable( "destroy" );
}

// currently resizable, changing handles
// Currently resizable, changing handles
if ( isResizable && typeof value === "string" ) {
uiDialog.resizable( "option", "handles", value );
}

// currently non-resizable, becoming resizable
// Currently non-resizable, becoming resizable
if ( !isResizable && value !== false ) {
this._makeResizable();
}
@@ -756,7 +756,7 @@ $.widget( "ui.dialog", {
options.width = options.minWidth;
}

// reset wrapper sizing
// Reset wrapper sizing
// determine the height of all the non-content elements
nonContentHeight = this.uiDialog.css( {
height: "auto",

0 comments on commit 9ef84a6

Please sign in to comment.
You can’t perform that action at this time.