Effects: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

tests/unit/effects/effects.html

@@ -4,39 +4,9 @@
 	<meta charset="utf-8">
 	<title>jQuery UI Effects Test Suite</title>
 
-	<script src="../../jquery.js"></script>
-	<link rel="stylesheet" href="../../../external/qunit/qunit.css">
-	<script src="../../../external/qunit/qunit.js"></script>
-	<script src="../../../external/jquery-simulate/jquery.simulate.js"></script>
-	<script src="../testsuite.js"></script>
-	<script src="../../../external/qunit-assert-classes/qunit-assert-classes.js"></script>
-	<script>
-	TestHelpers.loadResources({
-		js: [
-			"ui/effect.js",
-			"ui/effect-blind.js",
-			"ui/effect-bounce.js",
-			"ui/effect-clip.js",
-			"ui/effect-drop.js",
-			"ui/effect-explode.js",
-			"ui/effect-fade.js",
-			"ui/effect-fold.js",
-			"ui/effect-highlight.js",
-			"ui/effect-puff.js",
-			"ui/effect-pulsate.js",
-			"ui/effect-scale.js",
-			"ui/effect-shake.js",
-			"ui/effect-size.js",
-			"ui/effect-slide.js",
-			"ui/effect-transfer.js"
-		]
-	});
+	<script src="../../lib/css.js"></script>
+	<script src="../../lib/bootstrap.js" data-modules="effects_core effects_scale">
 	</script>
-
-	<script src="effects_core.js"></script>
-	<script src="effects_scale.js"></script>
-
-	<script src="../swarminject.js"></script>
 	<style>
 	#qunit-fixture {
 		width: 1000px;

tests/unit/effects/effects_core.js

@@ -1,4 +1,23 @@
-(function($) {
+define( [
+	"jquery",
+	"lib/common",
+	"ui/effect",
+	"ui/effect-blind",
+	"ui/effect-bounce",
+	"ui/effect-clip",
+	"ui/effect-drop",
+	"ui/effect-explode",
+	"ui/effect-fade",
+	"ui/effect-fold",
+	"ui/effect-highlight",
+	"ui/effect-puff",
+	"ui/effect-pulsate",
+	"ui/effect-scale",
+	"ui/effect-shake",
+	"ui/effect-size",
+	"ui/effect-slide",
+	"ui/effect-transfer"
+], function( $, common ) {
 
 function present( value, array, message ) {
 	QUnit.push( jQuery.inArray( value, array ) !== -1, value, array, message );
@@ -242,7 +261,7 @@ test( "createPlaceholder: preserves layout affecting properties", function() {
 $.each( $.effects.effect, function( effect ) {
 	module( "effects." + effect );
 
-	TestHelpers.testJshint( "effect-" + effect );
+	common.testJshint( "effect-" + effect );
 
 	if ( effect === "transfer" ) {
 		return;
@@ -319,4 +338,4 @@ $.each( $.effects.effect, function( effect ) {
 	});
 });
 
-})(jQuery);
+} );

tests/unit/effects/effects_scale.js

@@ -1,4 +1,8 @@
-(function( $ ) {
+define( [
+	"jquery",
+	"ui/effect-scale"
+], function( $ ) {
+
 module( "effect.scale: Scale" );
 
 function run( position, v, h, vo, ho ) {
@@ -65,4 +69,4 @@ $(function() {
 	}
 });
 
-})( jQuery );
+} );