Skip to content
Permalink
Browse files

Dialog: Don't bind overlay event handlers if the overlays are destroy…

…ed before the setTimeout block is executed - Fixes #4065 - modal dialog + button locks page.
  • Loading branch information
scottgonzalez committed Mar 28, 2009
1 parent 12b47dc commit a39d0d9350dc8589c61a793bb5aca4916406d737
Showing with 7 additions and 4 deletions.
  1. +7 −4 ui/ui.dialog.js
@@ -533,10 +533,13 @@ $.extend($.ui.dialog.overlay, {
// we use a setTimeout in case the overlay is created from an
// event that we're going to be cancelling (see #2804)
setTimeout(function() {
$(document).bind($.ui.dialog.overlay.events, function(event) {
var dialogZ = $(event.target).parents('.ui-dialog').css('zIndex') || 0;
return (dialogZ > $.ui.dialog.overlay.maxZ);
});
// handle $(el).dialog().dialog('close') (see #4065)
if ($.ui.dialog.overlay.instances.length) {
$(document).bind($.ui.dialog.overlay.events, function(event) {
var dialogZ = $(event.target).parents('.ui-dialog').css('zIndex') || 0;
return (dialogZ > $.ui.dialog.overlay.maxZ);
});
}
}, 1);

// allow closing by pressing the escape key

0 comments on commit a39d0d9

Please sign in to comment.
You can’t perform that action at this time.