Skip to content
Permalink
Browse files

Dialog: Don't return true when we don't want to cancel events. Fixes …

…#3523 - Dialog: onclick return value ignored.
  • Loading branch information...
scottgonzalez committed Aug 27, 2010
1 parent 1e28040 commit af9864dcc439bf8d04f4ade248725cc217f66d56
Showing with 4 additions and 1 deletion.
  1. +4 −1 ui/jquery.ui.dialog.js
@@ -693,7 +693,10 @@ $.extend($.ui.dialog.overlay, {
if ($.ui.dialog.overlay.instances.length) {
$(document).bind($.ui.dialog.overlay.events, function(event) {
// stop events if the z-index of the target is < the z-index of the overlay
return ($(event.target).zIndex() >= $.ui.dialog.overlay.maxZ);
// we cannot return true when we don't want to cancel the event (#3523)
if ($(event.target).zIndex() < $.ui.dialog.overlay.maxZ) {
return false;
}
});
}
}, 1);

0 comments on commit af9864d

Please sign in to comment.
You can’t perform that action at this time.