Skip to content
Permalink
Browse files

Spinner: modified _spin and _setOption to call new method _trimValue …

…to check for min/max values. Fixed #7264 - Spinner returns values beyond min and max, off by one
  • Loading branch information
ryanneufeld authored and gnarf committed Jun 14, 2011
1 parent e549e18 commit b0182d78229058fdf61d5f9c3b8a66617d056f30
Showing with 18 additions and 7 deletions.
  1. +18 −7 ui/jquery.ui.spinner.js
@@ -258,12 +258,29 @@ $.widget( "ui.spinner", {
: 2
: 1);

// clamp the new value
newVal = this._trimValue( newVal );

if ( this._trigger( "spin", event, { value: newVal } ) !== false) {
this.value( newVal );
this.counter++;
}
},

_trimValue: function( value ) {
var options = this.options;

if ( value > options.max) {
return options.max;
}

if ( value < options.min ) {
return options.min;
}

return value;
},

_stop: function( event ) {
this.counter = 0;
if ( this.timer ) {
@@ -280,13 +297,7 @@ $.widget( "ui.spinner", {

_setOption: function( key, value ) {
if ( key === "value") {
value = this._parse( value );
if ( value < this.options.min ) {
value = this.options.min;
}
if ( value > this.options.max ) {
value = this.options.max;
}
value = this._trimValue( this._parse(value) );
}

if ( key === "disabled" ) {

0 comments on commit b0182d7

Please sign in to comment.
You can’t perform that action at this time.