Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Sortable: Copy the src of the original item when creating a placehold…

…er from an image. Fixes #5129 - Sortable: Unable to use an image as a placeholder in Firefox.
  • Loading branch information...
commit b9be6bb7ad107fd48b28e31df972b2037c47c2cb 1 parent ca0b4b8
@scottgonzalez scottgonzalez authored
View
7 tests/unit/sortable/sortable.html
@@ -84,6 +84,13 @@ <h2 id="qunit-userAgent"></h2>
</tbody>
</table>
+<div id="sortable-images">
+ <img src="../images/jqueryui_32x32.png">
+ <img src="../images/jqueryui_32x32.png">
+ <img src="../images/jqueryui_32x32.png">
+ <img src="../images/jqueryui_32x32.png">
+</div>
+
</div>
</body>
</html>
View
21 tests/unit/sortable/sortable_options.js
@@ -5,10 +5,6 @@
module("sortable: options");
-// this is here to make JSHint pass "unused", and we don't want to
-// remove the parameter for when we finally implement
-$.noop();
-
/*
test("{ appendTo: 'parent' }, default", function() {
ok(false, "missing test - untested code is broken code.");
@@ -186,6 +182,23 @@ test("{ placeholder: false }, default", function() {
ok(false, "missing test - untested code is broken code.");
});
*/
+
+test( "{ placeholder: false } img", function() {
+ expect( 3 );
+
+ var element = $( "#sortable-images" ).sortable({
+ start: function( event, ui ) {
+ equal( ui.placeholder.attr( "src" ), "../images/jqueryui_32x32.png", "placeholder img has correct src" );
+ equal( ui.placeholder.height(), 32, "placeholder has correct height" );
+ equal( ui.placeholder.width(), 32, "placeholder has correct width" );
+ }
+ });
+
+ element.find( "img" ).eq( 0 ).simulate( "drag", {
+ dy: 1
+ });
+});
+
test( "{ placeholder: String }", function() {
expect( 1 );
View
2  ui/jquery.ui.sortable.js
@@ -762,6 +762,8 @@ $.widget("ui.sortable", $.ui.mouse, {
// width of the table (browsers are smart enough to
// handle this properly)
element.append( "<td colspan='99'>&#160;</td>" );
+ } else if ( nodeName === "img" ) {
+ element.attr( "src", that.currentItem.attr( "src" ) );
}
if ( !className ) {
Please sign in to comment.
Something went wrong with that request. Please try again.