Permalink
Browse files

Clicking on a draggable anchor without moving it should make it the a…

…ctive element (Fixes #8399).
  • Loading branch information...
steveluscher authored and mikesherov committed May 2, 2013
1 parent 91b7b9f commit bca3e058e89bf40806170149b8029dfe52644248
Showing with 17 additions and 0 deletions.
  1. +14 −0 tests/unit/draggable/draggable_core.js
  2. +3 −0 ui/jquery.ui.draggable.js
@@ -185,4 +185,18 @@ test( "#5727: draggable from iframe" , function() {
TestHelpers.draggable.shouldMove( draggable1 );
});
test( "#8399: A draggable should become the active element after you are finished interacting with it, but not before.", function() {
expect( 2 );
var element = $( "<a href='#'>link</a>" ).appendTo( "#qunit-fixture" ).draggable();
$( document ).one( "mousemove", function() {
notStrictEqual( document.activeElement, element.get( 0 ), "moving a draggable anchor did not make it the active element" );
});
TestHelpers.draggable.move( element, 50, 50 );
strictEqual( document.activeElement, element.get( 0 ), "finishing moving a draggable anchor made it the active element" );
});
})( jQuery );
@@ -263,6 +263,9 @@ $.widget("ui.draggable", $.ui.mouse, {
$.ui.ddmanager.dragStop(this, event);
}
// The interaction is over; whether or not the click resulted in a drag, focus the element
this.element.focus();
return $.ui.mouse.prototype._mouseUp.call(this, event);
},

0 comments on commit bca3e05

Please sign in to comment.