Skip to content
Permalink
Browse files

Spinner: ui() doesn't return instance

  • Loading branch information
chicheng committed Aug 19, 2008
1 parent bf1d243 commit c0147da718694cb5b571d2b2c4c206a1cd26012f
Showing with 6 additions and 18 deletions.
  1. +3 −12 tests/spinner.js
  2. +3 −6 ui/ui.spinner.js
@@ -7,42 +7,33 @@
module("spinner");

test("init", function() {
expect(3);
expect(2);

$("#spin").spinner();
ok(true, '.spinner() called on element');

$([]).spinner().remove();
ok(true, '.spinner() called on empty collection');

$('<input id="spinner_dis">').spinner().remove();
ok(true, '.spinner() called on disconnected element');

});

test("destroy", function() {
expect(3);
expect(2);

$("#spin").spinner().spinner("destroy");
ok(true, '.spinner("destroy") called on element');

$([]).spinner().spinner("destroy").remove();
ok(true, '.spinner().spinner("destroy") called on empty collection');

$('<input id="spinner_dis">').spinner().spinner("destroy").remove();
ok(true, '.spinner().spinner("destroy") called on disconnected element');

});

test("re-attach", function() {
expect(3);
expect(2);

el = $("#spin").spinner().spinner("destroy").spinner();
ok(true, '.spinner().spinner("destroy").spinner() called on element');

$([]).spinner().spinner("destroy").spinner().remove();
ok(true, '.spinner().spinner("destroy").spinner() called on empty collection');

$('<input id="spinner_dis">').spinner().spinner("destroy").spinner().remove();
ok(true, '.spinner().spinner("destroy").spinner() called on disconnected element');

@@ -204,7 +204,6 @@ $.widget('ui.spinner', {
plugins: {},
ui: function(e) {
return {
instance: this,
options: this.options,
element: this.element,
value: this._getValue()
@@ -216,7 +215,9 @@ $.widget('ui.spinner', {
},
destroy: function() {
if(!$.data(this.element[0], 'spinner')) return;

if ($.fn.mousewheel) {
this.element.unmousewheel();
}
this.element
.removeClass('ui-spinner-box')
.removeAttr('disabled')
@@ -230,10 +231,6 @@ $.widget('ui.spinner', {
.before(this.element.clone())
.remove()
.end();

if ($.fn.mousewheel) {
this.element.unmousewheel();
}
},
enable: function() {
this.element

0 comments on commit c0147da

Please sign in to comment.
You can’t perform that action at this time.