Skip to content
Permalink
Browse files

Revert "Dialog: Don't change DOM position on open. Fixes #6137 - dial…

…og('open') causes form elements to reset on IE7."

This reverts commit 67b1db1.

Reverting so I can commit again with the proper author.
  • Loading branch information
scottgonzalez committed Oct 4, 2010
1 parent 67b1db1 commit c090802cc1f92736288dafbea95bb2783392975e
Showing with 3 additions and 17 deletions.
  1. +0 −17 tests/unit/dialog/dialog_tickets.js
  2. +3 −0 ui/jquery.ui.dialog.js
@@ -61,21 +61,4 @@ test("#5531: dialog width should be at least minWidth on creation", function ()

});

test("#6137: dialog('open') causes form elements to reset on IE7", function() {
expect(2);

d1 = $('<form><input type="radio" name="radio" id="a" value="a" checked="checked"></input>' +
'<input type="radio" name="radio" id="b" value="b">b</input></form>').dialog({autoOpen: false});

d1.find('#b')[0].checked = true;
equal($('input:checked').val(), 'b', "checkbox b is checked");

d2 = $('<div></div>').dialog({autoOpen: false});

d1.dialog('open');
equal($('input:checked').val(), 'b', "checkbox b is checked");

d1.add(d2).remove();
})

})(jQuery);
@@ -309,6 +309,9 @@ $.widget("ui.dialog", {
uiDialog = self.uiDialog;

self.overlay = options.modal ? new $.ui.dialog.overlay(self) : null;
if (uiDialog.next().length) {
uiDialog.appendTo('body');
}
self._size();
self._position(options.position);
uiDialog.show(options.show);

0 comments on commit c090802

Please sign in to comment.
You can’t perform that action at this time.