Skip to content
Permalink
Browse files

Autocomplete: Revert fix for #7024, broke regular menu selection.

Disabled test for now (need to reopen ticket).
  • Loading branch information...
jzaefferer committed May 11, 2011
1 parent 85ac420 commit c17f245d9848ae865d400dabb02ea954aa8da645
Showing with 3 additions and 4 deletions.
  1. +2 −0 tests/unit/autocomplete/autocomplete_events.js
  2. +0 −1 ui/jquery.ui.autocomplete.js
  3. +1 −3 ui/jquery.ui.menu.js
@@ -203,6 +203,7 @@ test("cancel select", function() {
}, 50);
});

/* TODO previous fix broke more than it fixed, disabling this for now - messed up regular menu select event
test("blur without selection", function() {
expect(1);
var ac = $("#autocomplete").autocomplete({
@@ -218,5 +219,6 @@ test("blur without selection", function() {
start();
}, 50);
});
*/

})(jQuery);
@@ -365,7 +365,6 @@ $.widget( "ui.autocomplete", {
this.menu.element.hide();
this.menu.blur();
this._trigger( "close", event );
this.menu.isNewMenu = true;
}
},

@@ -18,7 +18,6 @@ var idIncrement = 0;
$.widget("ui.menu", {
defaultElement: "<ul>",
delay: 150,
isNewMenu: true,
options: {
position: {
my: "left top",
@@ -55,8 +54,7 @@ $.widget("ui.menu", {
self.select( event );
})
.bind( "mouseover.menu", function( event ) {
if ( self.options.disabled || self.isNewMenu ) {
self.isNewMenu = false;
if ( self.options.disabled ) {
return;
}
var target = $( event.target ).closest( ".ui-menu-item" );

0 comments on commit c17f245

Please sign in to comment.
You can’t perform that action at this time.