Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Selectmenu: small fix for _toggleAttr to make sure isOpen is not unde…

…fined
  • Loading branch information...
commit c5efddab2dc37b48d58d30fc78bd696d340c34c7 1 parent 1fbf5cb
@fnagel fnagel authored
Showing with 6 additions and 6 deletions.
  1. +6 −6 ui/jquery.ui.selectmenu.js
View
12 ui/jquery.ui.selectmenu.js
@@ -200,6 +200,7 @@ $.widget( "ui.selectmenu", {
this.button.trigger( "focus" );
}
+ this.isOpen = true;
this._toggleAttr();
if ( this.items && !this.options.dropdown ) {
@@ -225,15 +226,14 @@ $.widget( "ui.selectmenu", {
of: this.button
}, this.options.position ));
- this.isOpen = true;
this._trigger( "open", event );
}
},
close: function( event ) {
if ( this.isOpen ) {
- this._toggleAttr();
this.isOpen = false;
+ this._toggleAttr();
this._trigger( "close", event );
}
},
@@ -403,11 +403,11 @@ $.widget( "ui.selectmenu", {
_toggleAttr: function(){
if ( this.options.dropdown ) {
- this.button.toggleClass( 'ui-corner-top', !this.isOpen ).toggleClass( 'ui-corner-all', this.isOpen );
+ this.button.toggleClass( 'ui-corner-top', this.isOpen ).toggleClass( 'ui-corner-all', !this.isOpen );
}
- this.menuWrap.toggleClass( 'ui-selectmenu-open', !this.isOpen );
- this.menu.attr("aria-hidden", this.isOpen);
- this.button.attr("aria-expanded", !this.isOpen);
+ this.menuWrap.toggleClass( 'ui-selectmenu-open', this.isOpen );
+ this.menu.attr("aria-hidden", !this.isOpen);
+ this.button.attr("aria-expanded", this.isOpen);
},
_getCreateOptions: function() {
Please sign in to comment.
Something went wrong with that request. Please try again.