Skip to content
Permalink
Browse files

Button: properly escape button names. Fixes #7505 - Button: Buttonset…

… not applied to radio group with quotation/apostrophe in name.
  • Loading branch information
mikesherov committed Nov 19, 2012
1 parent 4334b5d commit cc7df712cc4ca90f6d6db599c5ff91b690921581
Showing with 17 additions and 1 deletion.
  1. +7 −0 tests/unit/button/button.html
  2. +9 −1 tests/unit/button/button_events.js
  3. +1 −0 ui/jquery.ui.button.js
@@ -59,6 +59,13 @@ <h2 id="qunit-userAgent"></h2>
<input type="radio" id="radio23" name="radio" checked="checked"><label for="radio23">Choice 3</label>
</div>
</form>
<form>
<div id="radio3">
<input type="radio" id="radio31" name="data['Page']['parse']" /><label for="radio31">Choice 1</label>
<input type="radio" id="radio32" name="data['Page']['parse']" checked="checked" /><label for="radio32">Choice 2</label>
<input type="radio" id="radio33" name="data['Page']['parse']" /><label for="radio33">Choice 3</label>
</div>
</form>​

<input type="checkbox" id="check"><label for="check">Toggle</label>

@@ -1,8 +1,16 @@
/*
* button_events.js
*/
(function() {
(function($) {

module("button: events");

test("buttonset works with single-quote named elements (#7505)", function() {
expect( 1 );
$("#radio3").buttonset();
$("#radio33").click( function(){
ok( true, "button clicks work with single-quote named elements" );
}).click();
});

})(jQuery);
@@ -29,6 +29,7 @@ var lastActive, startXPos, startYPos, clickDragged,
form = radio.form,
radios = $( [] );
if ( name ) {
name = name.replace( /'/g, "\\'" );
if ( form ) {
radios = $( form ).find( "[name='" + name + "']" );
} else {

0 comments on commit cc7df71

Please sign in to comment.
You can’t perform that action at this time.