Skip to content
Permalink
Browse files

Dialog: When animating dialog close, wait until after the animation c…

…ompletes before triggering the close event. Fixes #4207 - Dialog close event occurs too early with hide effect.
  • Loading branch information...
scottgonzalez committed Feb 21, 2009
1 parent 3342fb8 commit d94afbee78a065169928bedbe4d9c3a5e20eeaec
Showing with 12 additions and 7 deletions.
  1. +12 −7 ui/ui.dialog.js
@@ -154,19 +154,24 @@ $.widget("ui.dialog", {
},

close: function(event) {
if (false === this._trigger('beforeclose', event)) {
var self = this;

if (false === self._trigger('beforeclose', event)) {
return;
}

(this.overlay && this.overlay.destroy());
this.uiDialog
.hide(this.options.hide)
.unbind('keypress.ui-dialog');
(self.overlay && self.overlay.destroy());
self.uiDialog.unbind('keypress.ui-dialog');

(self.options.hide
? self.uiDialog.hide(self.options.hide, function() {
self._trigger('close', event);
})
: self._trigger('close', event));

this._trigger('close', event);
$.ui.dialog.overlay.resize();

this._isOpen = false;
self._isOpen = false;
},

isOpen: function() {

0 comments on commit d94afbe

Please sign in to comment.
You can’t perform that action at this time.