Skip to content
Permalink
Browse files

Menu: Handle clicking on a menu item without hovering it first. Fixes…

… #7085 - Menu click when no mouseover causes error.
  • Loading branch information...
scottgonzalez committed Mar 15, 2011
1 parent 9b3bade commit da67ece506ab69ef2d6d6bc6c1cf60be48776d4c
Showing with 7 additions and 2 deletions.
  1. +7 −2 ui/jquery.ui.menu.js
@@ -34,14 +34,19 @@ $.widget("ui.menu", {
role: "listbox"
})
.bind( "click.menu", function( event ) {
var item = $( event.target ).closest( ".ui-menu-item:has(a)" );
if ( self.options.disabled ) {
return false;
}
if ( !$( event.target ).closest( ".ui-menu-item a" ).length ) {
if ( !item.length ) {
return;
}
// temporary
event.preventDefault();
// it's possible to click an item without hovering it (#7085)
if ( !self.active || ( self.active[ 0 ] !== item[ 0 ] ) ) {
self.focus( event, item );
}
self.select( event );
})
.bind( "mouseover.menu", function( event ) {
@@ -102,7 +107,7 @@ $.widget("ui.menu", {
event.preventDefault();
break;
case $.ui.keyCode.ENTER:
self.select();
self.select( event );
event.preventDefault();
event.stopImmediatePropagation();
break;

0 comments on commit da67ece

Please sign in to comment.
You can’t perform that action at this time.