Skip to content
Permalink
Browse files
Sortable: Reset fromOutside property when canceling helper removal. F…
…ixes #8430 - draggable with sortable makes sortable event receive triggered wrong.
  • Loading branch information
wedgwood authored and scottgonzalez committed Jul 16, 2012
1 parent 0a1cd95 commit dcea4f043adc7f37674feead31ded148d311ab72
Showing 1 changed file with 2 additions and 0 deletions.
@@ -1030,6 +1030,8 @@ $.widget("ui.sortable", $.ui.mouse, {
for (var i=0; i < delayedTriggers.length; i++) { delayedTriggers[i].call(this, event); }; //Trigger all delayed events
this._trigger("stop", event, this._uiHash());
}

this.fromOutside = false;
return false;
}

5 comments on commit dcea4f0

@scottgonzalez
Copy link
Member

@scottgonzalez scottgonzalez commented on dcea4f0 Dec 16, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wedgwood Can you please sign our CLA?

@wedgwood
Copy link
Contributor Author

@wedgwood wedgwood commented on dcea4f0 Jan 5, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scottgonzalez Of course. I signed it.

@scottgonzalez
Copy link
Member

@scottgonzalez scottgonzalez commented on dcea4f0 Jan 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you signed twice with different email addresses and with a different order for you names. Which email address and which name are we supposed to use?

@wedgwood
Copy link
Contributor Author

@wedgwood wedgwood commented on dcea4f0 Jan 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scottgonzalez My fault. First sign was with carelessness. You could use the second one Baoju Yuan with email the_guy_1987@hotmail.com.

@scottgonzalez
Copy link
Member

@scottgonzalez scottgonzalez commented on dcea4f0 Jan 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please sign in to comment.