Permalink
Browse files

Slider: Switch handles from <a href="#"> to <span tabindex="0">

Fixes #9890
Closes gh-1207
  • Loading branch information...
tjvantoll committed Mar 6, 2014
1 parent 343c265 commit dfc5c34320691bd113250795243ea8b025b1f516
Showing with 6 additions and 10 deletions.
  1. +1 −1 demos/slider/multiple-vertical.html
  2. +5 −9 ui/slider.js
@@ -11,7 +11,7 @@
<script src="../../ui/slider.js"></script>
<link rel="stylesheet" href="../demos.css">
<style>
#eq span {
#eq > span {
height:120px; float:left; margin:15px
}
</style>
View
@@ -83,7 +83,7 @@ return $.widget( "ui.slider", $.ui.mouse, {
var i, handleCount,
options = this.options,
existingHandles = this.element.find( ".ui-slider-handle" ).addClass( "ui-state-default ui-corner-all" ),
handle = "<a class='ui-slider-handle ui-state-default ui-corner-all' href='#'></a>",
handle = "<span class='ui-slider-handle ui-state-default ui-corner-all' tabindex='0'></span>",
handles = [];
handleCount = ( options.values && options.values.length ) || 1;
@@ -149,11 +149,10 @@ return $.widget( "ui.slider", $.ui.mouse, {
},
_setupEvents: function() {
var elements = this.handles.add( this.range ).filter( "a" );
this._off( elements );
this._on( elements, this._handleEvents );
this._hoverable( elements );
this._focusable( elements );
this._off( this.handles );
this._on( this.handles, this._handleEvents );
this._hoverable( this.handles );
this._focusable( this.handles );
},
_destroy: function() {
@@ -673,9 +672,6 @@ return $.widget( "ui.slider", $.ui.mouse, {
this._slide( event, index, newVal );
},
click: function( event ) {
event.preventDefault();
},
keyup: function( event ) {
var index = $( event.target ).data( "ui-slider-handle-index" );

0 comments on commit dfc5c34

Please sign in to comment.