Skip to content
Permalink
Browse files

Removing unnecessary variables, caching 'within' in tests where its b…

…eneficial, and making some other changes based on the code review
  • Loading branch information...
David Murdoch
David Murdoch committed May 16, 2011
1 parent f798b04 commit e4a42991df74955294d0cfa95273722eb006969d
Showing with 83 additions and 201 deletions.
  1. +3 −2 tests/unit/position/position_core.js
  2. +72 −187 tests/unit/position/position_core_within.js
  3. +8 −12 ui/jquery.ui.position.js
@@ -314,7 +314,8 @@ test( "collision: fit, with offset", function() {
test( "collision: fit, window scrolled", function() {
if ( scrollTopSupport() ) {
var win = $( window );
$( window ).scrollTop( 300 ).scrollLeft( 200 );
win.scrollTop( 300 ).scrollLeft( 200 );

collisionTest({
collision: "fit",
at: "left-100 top-100"
@@ -323,7 +324,7 @@ test( "collision: fit, window scrolled", function() {
collision: "fit",
at: "right+100 bottom+100"
}, { top: 300 + win.height() - 10, left: 200 + win.width() - 10 }, "right bottom" );

win.scrollTop( 0 ).scrollLeft( 0 );
}
});

0 comments on commit e4a4299

Please sign in to comment.
You can’t perform that action at this time.