Permalink
Browse files

Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open…

…') causes form elements to reset on IE7.
  • Loading branch information...
John Firebaugh authored and scottgonzalez committed Oct 1, 2010
1 parent c090802 commit e66cdfcf59f3a03bb3c49337f8c11da0a236b337
Showing with 17 additions and 3 deletions.
  1. +17 −0 tests/unit/dialog/dialog_tickets.js
  2. +0 −3 ui/jquery.ui.dialog.js
@@ -61,4 +61,21 @@ test("#5531: dialog width should be at least minWidth on creation", function ()
});
test("#6137: dialog('open') causes form elements to reset on IE7", function() {
expect(2);
d1 = $('<form><input type="radio" name="radio" id="a" value="a" checked="checked"></input>' +
'<input type="radio" name="radio" id="b" value="b">b</input></form>').dialog({autoOpen: false});
d1.find('#b')[0].checked = true;
equal($('input:checked').val(), 'b', "checkbox b is checked");
d2 = $('<div></div>').dialog({autoOpen: false});
d1.dialog('open');
equal($('input:checked').val(), 'b', "checkbox b is checked");
d1.add(d2).remove();
})
})(jQuery);
View
@@ -309,9 +309,6 @@ $.widget("ui.dialog", {
uiDialog = self.uiDialog;
self.overlay = options.modal ? new $.ui.dialog.overlay(self) : null;
if (uiDialog.next().length) {
uiDialog.appendTo('body');
}
self._size();
self._position(options.position);
uiDialog.show(options.show);

0 comments on commit e66cdfc

Please sign in to comment.