Skip to content
Permalink
Browse files

Dialog: Refactor uiDialogTitlebar variable, use this.uiDialogTitlebar…

… instead. Wasn't needed anymore (previous refactorings).
  • Loading branch information...
jzaefferer committed Nov 15, 2012
1 parent 7a03535 commit f0acaac230b70b3754ef3aabe8fc90f23fbb6a88
Showing with 5 additions and 7 deletions.
  1. +5 −7 ui/jquery.ui.dialog.js
@@ -93,8 +93,6 @@ $.widget("ui.dialog", {
var that = this,
options = this.options,
title = options.title || " ",
// TODO should use this.uiDialogTitlebar instead
uiDialogTitlebar,
uiDialogTitle,
uiDialogButtonPane;

@@ -124,11 +122,11 @@ $.widget("ui.dialog", {
.addClass( "ui-dialog-content ui-widget-content" )
.appendTo( this.uiDialog );

// TODO extract this and the next three into a _createTitlebar method
uiDialogTitlebar = ( this.uiDialogTitlebar = $( "<div>" ) )
// TODO extract this and the next two into a _createTitlebar method
this.uiDialogTitlebar = $( "<div>" )
.addClass( "ui-dialog-titlebar ui-widget-header ui-corner-all ui-helper-clearfix" )
.prependTo( this.uiDialog );
this._on( uiDialogTitlebar, {
this._on( this.uiDialogTitlebar, {
mousedown: function() {
// TODO call _focusTabbable or _keepFocus
// Dialog isn't getting focus when dragging (#8063)
@@ -149,13 +147,13 @@ $.widget("ui.dialog", {
event.preventDefault();
that.close( event );
})
.appendTo( uiDialogTitlebar );
.appendTo( this.uiDialogTitlebar );

uiDialogTitle = $( "<span>" )
.uniqueId()
.addClass( "ui-dialog-title" )
.html( title )
.prependTo( uiDialogTitlebar );
.prependTo( this.uiDialogTitlebar );

// TODO extract this one and the next into a _createButtonPane method
uiDialogButtonPane = ( this.uiDialogButtonPane = $( "<div>" ) )

0 comments on commit f0acaac

Please sign in to comment.
You can’t perform that action at this time.