Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Don't use .min.js extension for individual source files #1466

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@scottgonzalez
Copy link
Member

scottgonzalez commented Mar 4, 2015

We don't actually use these files for anything other than size comparisons,
but having the .min.js extension means that AMD is broken.

Note: If you're using AMD with the minified files, just run a build instead.

Fixes #10674

@rxaviers Can you just re-confirm that these file aren't used by download builder?

Build: Don't use .min.js extension for individual source files
We don't actually use these files for anything other than size comparisons,
but having the .min.js extension means that AMD is broken.

Note: If you're using AMD with the minified files, just run a build instead.

Fixes #10674

@jquerybot jquerybot added the CLA: Valid label Mar 4, 2015

@rxaviers

This comment has been minimized.

Copy link
Member

rxaviers commented Mar 4, 2015

@scottgonzalez correct. Download Builder generates the minified files. Those are not used.

@tjvantoll

This comment has been minimized.

Copy link
Member

tjvantoll commented Mar 5, 2015

👍 This is much simpler than I thought it would be.

@scottgonzalez

This comment has been minimized.

Copy link
Member Author

scottgonzalez commented Mar 5, 2015

This is much simpler than I thought it would be.

That's because I took the simple way out ;-) The hard way would be stripping the wrappers and then saying "HA, for real don't use AMD on minified files." 😏

@scottgonzalez scottgonzalez deleted the scottgonzalez:amd-minified branch Mar 5, 2015

@jacquerie jacquerie referenced this pull request Mar 11, 2015

Open

Better Issue Tracking #4

0 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.