Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert test infrastructure to AMD #1528

Closed
wants to merge 29 commits into from

Conversation

Projects
None yet
4 participants
@scottgonzalez
Copy link
Member

scottgonzalez commented Apr 3, 2015

This PR replaces #1511.

TODO:

Either now or near future:

  • Replace custom QUnit.assert.close() with qunit-assert-close module
  • Move domEqual() to its own module
  • Update visual tests to use AMD

@jquerybot jquerybot added the CLA: Valid label Apr 3, 2015

@scottgonzalez scottgonzalez referenced this pull request Apr 3, 2015

Closed

Tests: Replace resource loader with AMD #1511

5 of 10 tasks complete

@scottgonzalez scottgonzalez force-pushed the scottgonzalez:amd-tests2 branch 6 times, most recently from 0f3b6e1 to 315d16b Apr 6, 2015

@jzaefferer

This comment has been minimized.

Copy link
Member

jzaefferer commented Apr 8, 2015

Reviewed as-is, looks good. I like the renames.

@scottgonzalez

This comment has been minimized.

Copy link
Member Author

scottgonzalez commented Apr 8, 2015

Reviewed as-is, looks good.

That's good because the remaining changes are trivial :-)

@arschmitz

This comment has been minimized.

Copy link
Member

arschmitz commented Apr 8, 2015

Just for the record I reviewed all the changes with @scottgonzalez over irc / skype and am +1 on everything.

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

Tests: Change test infrastructure to use AMD and reduce boilerplate
Ref #10119
Ref gh-1528

* Adds RequireJS and relies on AMD for loading dependencies.
* Updates to grunt-contrib-qunit 0.6.0.
* Convert `domEqual()` to a proper QUnit assertion.
* Introduces two bootstrap files (JS and CSS) which use `data-` attributes to
reduce the amount of boilerplate needed in each test

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

Tests: Convert closeEnough() to a proper QUnit assertion
Should eventually replace with qunit-assert-close.

Ref #10119
Ref gh-1528

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

scottgonzalez added a commit that referenced this pull request Apr 9, 2015

Tests: Use the qunit-assert-close module
Moved QUnit assertion dependencies from `lib/bootstrap` to `lib/qunit`.

Corrected bad draggable assertions.

Ref gh-1528

@scottgonzalez scottgonzalez deleted the scottgonzalez:amd-tests2 branch Apr 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.