From 68b290d3227fcd906dc51f9d276c04414e5c17ad Mon Sep 17 00:00:00 2001 From: Scott Dutton Date: Tue, 15 Sep 2015 19:45:22 +0100 Subject: [PATCH] Autocomplete for Chrome Fixed Chrome since Version 34 has not followed the standard "off" setting setting to false seems to work on other browsers --- tests/unit/autocomplete/options.js | 7 +++++++ ui/widgets/autocomplete.js | 5 ++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/tests/unit/autocomplete/options.js b/tests/unit/autocomplete/options.js index 76c13e754c8..ec77ffe5837 100644 --- a/tests/unit/autocomplete/options.js +++ b/tests/unit/autocomplete/options.js @@ -316,4 +316,11 @@ test( "source, update after init", function() { equal( menu.find( ".ui-menu-item" ).text(), "php" ); } ); +test( "Autocomplete attribute", function() { + expect( 1 ); + var element = $( "#autocomplete" ).autocomplete(); + equal( element.attr( "autocomplete" ), "false", + "Should be false, Off prevents chrome working" ); +} ); + } ); diff --git a/ui/widgets/autocomplete.js b/ui/widgets/autocomplete.js index 1ebd6ed7ad1..611b36fd1b4 100644 --- a/ui/widgets/autocomplete.js +++ b/ui/widgets/autocomplete.js @@ -88,7 +88,10 @@ $.widget( "ui.autocomplete", { this.isNewMenu = true; this._addClass( "ui-autocomplete-input" ); - this.element.attr( "autocomplete", "off" ); + + //Chrome 34+ does not respect "off" + //All other browsers seem to accept "false" + this.element.attr( "autocomplete", "false" ); this._on( this.element, { keydown: function( event ) {