Calendar: callback return values, add refresh callback #1786

Merged
merged 3 commits into from Jan 25, 2017

Conversation

Projects
None yet
3 participants
@fnagel
Member

fnagel commented Jan 21, 2017

No description provided.

@fnagel fnagel self-assigned this Jan 21, 2017

@jzaefferer

jzaefferer approved these changes Jan 24, 2017 edited

Diif looks good.

To clarify: Why do we include this.options.value on change and select events when it could be retrieved through the options method?

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Jan 24, 2017

Member

To clarify: Why do we include this.options.value on change and select events when it could be retrieved through the options method?

Providing the value just makes it a little nicer to work with and creates consistency with other widgets where the selected values may not be easily retrievable, such as autocomplete and selectmenu.

Member

scottgonzalez commented Jan 24, 2017

To clarify: Why do we include this.options.value on change and select events when it could be retrieved through the options method?

Providing the value just makes it a little nicer to work with and creates consistency with other widgets where the selected values may not be easily retrievable, such as autocomplete and selectmenu.

@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Jan 24, 2017

Member

Providing the value just makes it a little nicer to work with and creates consistency with other widgets where the selected values may not be easily retrievable, such as autocomplete and selectmenu.

👍

Good to land then.

Member

jzaefferer commented Jan 24, 2017

Providing the value just makes it a little nicer to work with and creates consistency with other widgets where the selected values may not be easily retrievable, such as autocomplete and selectmenu.

👍

Good to land then.

@fnagel fnagel merged commit 767d173 into jquery:datepicker Jan 25, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment