Resizable: Fix content shrink on resize#2281
Conversation
Resizable element shrinks on resize when it has scrollbars and "box-sizing: content-box". Fixes: jquerygh-2277
|
@Daniel-Garmig do you know a way I can "MonkeyPatch" your fix on top of existing jQuery UI? We do stuff like this in our app to patch other jquery UI functions but the magic is never quite the same for all patches. I would like to be able to apply this patch until its accepted by jQueryUI team or (gulp) rejected. |
|
@mgol I have changed the method to avoid using I tried to optimize it, so this calculation is only done when necessary. After a resize, width and height properties will be added as inline css to the element, so I will use those when available to avoid the expensive calculation. I added some test for resizable elements with Let me know what do you think. |
mgol
left a comment
There was a problem hiding this comment.
Almost ready! Just two more comments from me.
|
Changes done! |
fnagel
left a comment
There was a problem hiding this comment.
+1 by reading and by running the unit tests (can confirm the new test will fail in Chrome if the fix is not present)
|
Landed, thanks! |
|
jQuery UI 1.14.1 with this change has been released. |
Fixes: #2277.
This end up being a bug on "resizable", and as I have shown on the issue it's quite a weird behavior and it's not consistent across browsers.
The same bug applies to the resizable element and "alsoResize" elements, so I fixed it on both places.
Dialog widget uses "alsoResize" property to update dialog contents size (as seen on the initial issue). This PR fixes that as well.
I have added some tests for both "box-sizing: content-box" and "box-sizing: border-box".