TIcket 5253 fix. #264

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

Contributor
lordt commented May 12, 2011

Fix for http://bugs.jqueryui.com/ticket/5253.

How can I change the ticket owner in bug tracker?

@lordt lordt closed this May 12, 2011
@toddparker toddparker commented on the diff May 18, 2011
demos/button/toolbar.html
@@ -11,8 +11,11 @@
<link rel="stylesheet" href="../demos.css">
<style>
#toolbar {
- padding: 10px 4px;
- }
+ padding: 11px 4px 9px 4px;
+ }
+ *:first-child+html #toolbar {
toddparker
toddparker May 18, 2011

What is this rule for?

lordt
lordt May 18, 2011 Contributor

THis is IE7 only selector

toddparker
toddparker May 18, 2011

Ok, sounds like all these changes check out. Thanks!

lordt
lordt May 18, 2011 Contributor

I close this pull-request for make new one: #292 which also works with ie6

@toddparker toddparker commented on the diff May 18, 2011
themes/base/jquery.ui.button.css
@@ -14,7 +14,7 @@ button.ui-button-icon-only { width: 2.4em; } /* button elements seem to need a l
button.ui-button-icons-only { width: 3.7em; }
/*button text element */
-.ui-button .ui-button-text { display: block; line-height: 1.4; }
+.ui-button .ui-button-text { display: inline-block; line-height: 1.4; }
toddparker
toddparker May 18, 2011

What's the switch to inline-block for? Does it affect the way the wrapping happens at smaller sizes?

lordt
lordt May 18, 2011 Contributor

.ui-button-text have padding styles, so where set to block, that the padding could work. However they should stay inline, as they default are, so I use inline-block.

toddparker
toddparker May 18, 2011

Gotcha, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment