GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Previous pull request: #265.
Button: Strange space between buttons in IE 7. Fixed #5253 Toolbar de…
…mo ugly in IE
Also check #7036 when reviewing.
More than 3 months for checking such small changes...
@lordt, sorry for taking such a long time to get back to you! It seems that since we've dropped support for IE6, that the only change really needed here is the zoom:1. Is that true? If so, can you update the pull request here so I can attempt to merge it in?
Thanks again for contributing, and sorry for the delay!
No, display-inline is also important. I won't change it.
@jzaefferer @scottgonzalez can someone review this pull request and see if these changes come with any side effects? I'd like to land it if its good.
It seems like it should be fine. I'd just add a /* support: IE7 */ comment in the demo file, and of course the theme changes will need to be redone because of the formatting.
/* support: IE7 */
@lordt, can please make the changes requested and sign the CLA: http://jquery.github.com/cla.html
@scottgonzalez what is wrong with formatting?
Pull master and you'll see. All of the CSS has been reformatted since you sent this PR.
@scottgonzalez @mikesherov And what would you do if I will not do that?
We'll make the changes ourselves and commit with you as the author :-)
@lordt, if you were not willing to sign the CLA, we would not accept the patch, and close this pull request. We would then wait till someone else authored a different fix for this, and land that patch instead.