Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Button: Strange space between buttons in IE 7. Fixed #5253 #292

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

lordt commented May 16, 2011

Previous pull request: #265.

  1. I changed the toolbar.html, so now it also works in IE 6, how ever I
    don't paste the display:inline-block in #toolbar, because it produces
    not this same result, as without it.
  2. About zoom:1 in ui-widget-header (jquery.ui.theme.css).
    Zoom is IE-only property, so I tested many demos in IE (versions: 6,7,8,9) and there
    is no problem with zoom:1 on all versions IE >= 6. So I don't see any
    contra to commit it into jquery-ui css files.
Owner

scottgonzalez commented May 18, 2011

Also check #7036 when reviewing.

Contributor

lordt commented Aug 24, 2011

More than 3 months for checking such small changes...

Member

mikesherov commented Nov 11, 2012

@lordt, sorry for taking such a long time to get back to you! It seems that since we've dropped support for IE6, that the only change really needed here is the zoom:1. Is that true? If so, can you update the pull request here so I can attempt to merge it in?

Thanks again for contributing, and sorry for the delay!

Contributor

lordt commented Nov 12, 2012

No, display-inline is also important. I won't change it.

Member

mikesherov commented Nov 25, 2012

@jzaefferer @scottgonzalez can someone review this pull request and see if these changes come with any side effects? I'd like to land it if its good.

Owner

scottgonzalez commented Nov 27, 2012

It seems like it should be fine. I'd just add a /* support: IE7 */ comment in the demo file, and of course the theme changes will need to be redone because of the formatting.

Member

mikesherov commented Nov 27, 2012

@lordt, can please make the changes requested and sign the CLA: http://jquery.github.com/cla.html

Contributor

lordt commented Nov 27, 2012

@scottgonzalez what is wrong with formatting?

Owner

scottgonzalez commented Nov 27, 2012

Pull master and you'll see. All of the CSS has been reformatted since you sent this PR.

Contributor

lordt commented Nov 27, 2012

@scottgonzalez @mikesherov And what would you do if I will not do that?

Owner

scottgonzalez commented Nov 27, 2012

We'll make the changes ourselves and commit with you as the author :-)

Member

mikesherov commented Nov 27, 2012

@lordt, if you were not willing to sign the CLA, we would not accept the patch, and close this pull request. We would then wait till someone else authored a different fix for this, and land that patch instead.

@mikesherov mikesherov closed this Nov 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment