Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Button: Strange space between buttons in IE 7. Fixed #5253 #292

Closed
wants to merge 1 commit into from

3 participants

lordt Scott González Mike Sherov
lordt
lordt commented

Previous pull request: #265.

  1. I changed the toolbar.html, so now it also works in IE 6, how ever I
    don't paste the display:inline-block in #toolbar, because it produces
    not this same result, as without it.

  2. About zoom:1 in ui-widget-header (jquery.ui.theme.css).
    Zoom is IE-only property, so I tested many demos in IE (versions: 6,7,8,9) and there
    is no problem with zoom:1 on all versions IE >= 6. So I don't see any
    contra to commit it into jquery-ui css files.

Scott González
Owner

Also check #7036 when reviewing.

lordt

More than 3 months for checking such small changes...

Mike Sherov
Collaborator

@lordt, sorry for taking such a long time to get back to you! It seems that since we've dropped support for IE6, that the only change really needed here is the zoom:1. Is that true? If so, can you update the pull request here so I can attempt to merge it in?

Thanks again for contributing, and sorry for the delay!

lordt

No, display-inline is also important. I won't change it.

Mike Sherov
Collaborator

@jzaefferer @scottgonzalez can someone review this pull request and see if these changes come with any side effects? I'd like to land it if its good.

Scott González

It seems like it should be fine. I'd just add a /* support: IE7 */ comment in the demo file, and of course the theme changes will need to be redone because of the formatting.

Mike Sherov
Collaborator

@lordt, can please make the changes requested and sign the CLA: http://jquery.github.com/cla.html

lordt

@scottgonzalez what is wrong with formatting?

Scott González

Pull master and you'll see. All of the CSS has been reformatted since you sent this PR.

lordt

@scottgonzalez @mikesherov And what would you do if I will not do that?

Scott González

We'll make the changes ourselves and commit with you as the author :-)

Mike Sherov
Collaborator

@lordt, if you were not willing to sign the CLA, we would not accept the patch, and close this pull request. We would then wait till someone else authored a different fix for this, and land that patch instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

May 16, 2011
lordt lordt Button: Strange space between buttons in IE 7. Fixed #5253 Toolbar de…
…mo ugly in IE
ea16e78
This page is out of date. Refresh to see the latest.
5 demos/button/toolbar.html
@@ -11,8 +11,9 @@
11 11 <link rel="stylesheet" href="../demos.css">
12 12 <style>
13 13 #toolbar {
14   - padding: 10px 4px;
15   - }
  14 + padding: 11px 4px 9px 4px;
  15 + *padding: 4px 0px 4px 5px;
  16 + }
16 17 </style>
17 18 <script>
18 19 $(function() {
2  themes/base/jquery.ui.button.css
@@ -14,7 +14,7 @@ button.ui-button-icon-only { width: 2.4em; } /* button elements seem to need a l
14 14 button.ui-button-icons-only { width: 3.7em; }
15 15
16 16 /*button text element */
17   -.ui-button .ui-button-text { display: block; line-height: 1.4; }
  17 +.ui-button .ui-button-text { display: inline-block; line-height: 1.4; }
18 18 .ui-button-text-only .ui-button-text { padding: .4em 1em; }
19 19 .ui-button-icon-only .ui-button-text, .ui-button-icons-only .ui-button-text { padding: .4em; text-indent: -9999999px; }
20 20 .ui-button-text-icon-primary .ui-button-text, .ui-button-text-icons .ui-button-text { padding: .4em 1em .4em 2.1em; }
2  themes/base/jquery.ui.theme.css
@@ -18,7 +18,7 @@
18 18 .ui-widget input, .ui-widget select, .ui-widget textarea, .ui-widget button { font-family: Verdana,Arial,sans-serif/*{ffDefault}*/; font-size: 1em; }
19 19 .ui-widget-content { border: 1px solid #aaaaaa/*{borderColorContent}*/; background: #ffffff/*{bgColorContent}*/ url(images/ui-bg_flat_75_ffffff_40x100.png)/*{bgImgUrlContent}*/ 50%/*{bgContentXPos}*/ 50%/*{bgContentYPos}*/ repeat-x/*{bgContentRepeat}*/; color: #222222/*{fcContent}*/; }
20 20 .ui-widget-content a { color: #222222/*{fcContent}*/; }
21   -.ui-widget-header { border: 1px solid #aaaaaa/*{borderColorHeader}*/; background: #cccccc/*{bgColorHeader}*/ url(images/ui-bg_highlight-soft_75_cccccc_1x100.png)/*{bgImgUrlHeader}*/ 50%/*{bgHeaderXPos}*/ 50%/*{bgHeaderYPos}*/ repeat-x/*{bgHeaderRepeat}*/; color: #222222/*{fcHeader}*/; font-weight: bold; }
  21 +.ui-widget-header { border: 1px solid #aaaaaa/*{borderColorHeader}*/; background: #cccccc/*{bgColorHeader}*/ url(images/ui-bg_highlight-soft_75_cccccc_1x100.png)/*{bgImgUrlHeader}*/ 50%/*{bgHeaderXPos}*/ 50%/*{bgHeaderYPos}*/ repeat-x/*{bgHeaderRepeat}*/; color: #222222/*{fcHeader}*/; font-weight: bold; zoom:1;}
22 22 .ui-widget-header a { color: #222222/*{fcHeader}*/; }
23 23
24 24 /* Interaction states

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.