Menu: Added radio and checkbox functionality to menu and a visual test #381

Closed
wants to merge 4 commits into from

2 participants

@kborchers
jQuery Foundation member

Menu: Added radio and checkbox functionality to menu and a visual test

@jzaefferer
jQuery Foundation member

Would be great to add the right ARIA roles as well. Here's a menubar example that includes those: http://oaa-accessibility.org/examplep/menubar1/

@kborchers
jQuery Foundation member

Definitely. I will add those, re-base and re-commit.

@kborchers
jQuery Foundation member

@jzaefferer I am adding the ARIA roles to the checkbox and radio items but I noticed that regular menu items have a role of presentation. Shouldn't that be set to a role of menuitem, and if so, would you like me to update that with this code or in another pull?

@kborchers
jQuery Foundation member

Wow, that got messy. Not sure how to fix that. Should I just delete this branch and start over with a new pull or is this ok?

@kborchers
jQuery Foundation member

This is just bothering me. I am going to start over and issue a new pull request. See #391

@kborchers kborchers closed this Jul 13, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment