Menu: Changed closeAll to collapseAll and updated in Menubar, also updated a reference to left in Menubar to collapse. #394

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Owner

kborchers commented Jul 14, 2011

Menu: Changed closeAll to collapseAll and updated in Menubar, also updated a reference to left in Menubar to collapse.

ui/jquery.ui.menu.js
+ },
+ keydown: function( event ) {
+ if ( event.keyCode === $.ui.keyCode.ESCAPE ) {
+ this.collapseAll();
@jzaefferer

jzaefferer Jul 14, 2011

Owner

I guess this makes sense for the case where the menu is opened on mouseover, without it having focus (therfore can't use keybinding on menu itself). Though I wonder if there should be a check to see if the menu is open or something. This code will basically run on each escape keypress, independent of what that may actually be intended to do.

Menu: Changed closeAll to collapseAll and updated in Menubar, also up…
…dated a reference to left in Menubar to collapse.
Owner

jzaefferer commented Jul 14, 2011

Landed.

@jzaefferer jzaefferer closed this Jul 14, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment