Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Menu: Added alignment option and ability to top align submenus as well as a demo #405

Merged
merged 1 commit into from Jul 27, 2011

Conversation

Projects
None yet
2 participants
Owner

kborchers commented Jul 26, 2011

Menu: Added alignment option and ability to top align submenus as well as a demo

Owner

jzaefferer commented Jul 26, 2011

I still don't see how a new option is required for that. In general, adding options is not an option - I'm pretty sure the same can be achieved by customizing the position option.

Owner

kborchers commented Jul 26, 2011

I do see what you're saying now. Your suggestion of position: { of: "ul" } doesn't work though for menus that have more than one submenu as they start stacking on top of each other being positioned next to the top-most ul. I'm trying to work out a selector that will do it.

Owner

kborchers commented Jul 26, 2011

There we go. Had to use position: { of: "ul:has(a.ui-state-focus):last" } but it works now without modification to Menu.

@jzaefferer jzaefferer merged commit c195757 into jquery:master Jul 27, 2011

Owner

jzaefferer commented Jul 27, 2011

Had to update jquery-1.6.2 reference and add it to the index. Works fine otherwise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment