Fix for bug #7639#443
Closed
meh-uk wants to merge 8 commits into
Closed
Conversation
added 6 commits
August 23, 2011 20:37
…rows is optional. Fixed #7639 - autocomplete: Key up/key down in textarea's should optionally not toggle auto-complete
…down in textarea's should optionally not toggle auto-complete
… defaults test. Bug #7639 - autocomplete: Key up/key down in textarea's should optionally not toggle auto-complete
…own in textarea's should optionally not toggle auto-complete
… down in textarea's should optionally not toggle auto-complete
…ork with textareas
Author
|
Sorry guys I've got a little mixed up here - I've also added my failing test for bug #7674. |
… down in textarea's should optionally not toggle auto-complete.
Member
|
This should definitely not be a tri-state option. Either the up/down arrows should activate a menu or they shouldn't. When the menu is active, the arrows should always navigate the menu. This needs a better name than upDownArrows. Please only send relevant commits in your pull request. You'll need to branch to properly send pull requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for bug #7639 including unit tests.