Mask & Timepicker - Code Review #494

Closed
wants to merge 118 commits into
from
Commits on Jul 27, 2011
  1. Mask tests: cleanup.

    scottgonzalez committed Jul 27, 2011
Commits on Jul 29, 2011
Commits on Jul 31, 2011
  1. Mask: adding a _validValue helper

    gnarf committed Jul 31, 2011
  2. Mask: Adding refresh method, Adding unit tests for mask/placeholder o…

    gnarf committed Jul 31, 2011
    …ption, backspace & delete behavior.
Commits on Aug 1, 2011
  1. Mask: adding a value method to get and set raw value without mask lit…

    gnarf committed Aug 1, 2011
    …erals / placeholders
Commits on Aug 2, 2011
  1. Mask: Updating regexp to include ö and å (etc), also making sure inpu…

    gnarf committed Aug 2, 2011
    …ts have focus in the tests to stop an odd sometimes bug
  2. Mask: Visual Test

    gnarf committed Aug 2, 2011
  3. Mask: Handling overtyping multiple values better - rewrote shiftRight…

    gnarf committed Aug 2, 2011
    … function to make more sense
Commits on Aug 10, 2011
  1. Mask: Adding the complete event

    gnarf committed Aug 10, 2011
  2. Mask: Updating visual test

    gnarf committed Aug 10, 2011
Commits on Aug 12, 2011
  1. Mask: clearEmpty option

    gnarf committed Aug 12, 2011
  2. Mask: Correcting typo

    gnarf committed Aug 12, 2011
  3. Mask: Fixing global leak

    gnarf committed Aug 12, 2011
  4. Mask: Update to visual tests

    gnarf committed Aug 12, 2011
Commits on Sep 12, 2011
  1. Merge branch 'master' into mask

    jzaefferer committed Sep 12, 2011
    Conflicts:
    	tests/unit/all.html
  2. Mask: Refactor _events method into _events property, pass to _bind on…

    jzaefferer committed Sep 12, 2011
    … _create. Matches design in Spinner
Commits on Sep 13, 2011
Commits on Sep 14, 2011
  1. Mask: Adding left key event to also highlight each field in multi-cha…

    gnarf committed Sep 14, 2011
    …racter fields like the right arrow was doing
    
    Conflicts:
    
    	ui/jquery.ui.mask.js
  2. Mask: fixing some merge conflicts

    gnarf committed Sep 14, 2011
  3. Mask: Fixing a focus caret position issue, adding _caretSelect to sel…

    gnarf committed Sep 14, 2011
    …ect a multi-byte field, canceling the caret on focus timeout in blur to prevent a possible loop when tabbing quickly between masked inputs
  4. Timepicker: Changing 'pp' to 'tt' to be more compatible with the form…

    gnarf committed Sep 14, 2011
    …at used in Globalize
Commits on Sep 15, 2011
  1. Mask: removing the complete event

    gnarf committed Sep 15, 2011
Commits on Sep 19, 2011
Commits on Sep 22, 2011
Commits on Sep 26, 2011
  1. Mask: Fixing a Unit failure in IE

    gnarf committed Sep 26, 2011
Commits on Sep 27, 2011
  1. Timepicker: Globalize support

    gnarf committed Sep 27, 2011
Commits on Sep 28, 2011
Commits on Oct 5, 2011
Commits on Oct 11, 2011
  1. Mask: fixing a broken unit test

    gnarf committed Oct 11, 2011
  2. Mask: Updating code with some suggestions from review

    gnarf committed Oct 11, 2011
    * remove docs link in header
    * call refresh from _create instead of _parseValue() _paint()
    * _paint call from _setOption should be in _setOptions
    * add ui-mask class to the element and remove in destroy...
    * refactor LEFT & RIGHT to be the same code - remove the bufferObject in these events...
    * remove currentEvent
    * comment in blur function needs whitespace
    * kill return at end of blur
Commits on Oct 12, 2011
  1. Mask: More updates from review - adresses comments from @jzaeffer

    gnarf committed Oct 12, 2011
    * make definitions test in the options.
    * remove return true from _caretSelect
    * check out backspace/delete see if i can remove double assign/ternary
  2. Mask: Optional fields not displayed until the value is 'valid', or th…

    gnarf committed Oct 12, 2011
    …ere are characters in the 'optional' area
  3. Mask: Tweaks to optional position handling - should now hide optional…

    gnarf committed Oct 12, 2011
    … section after focus leaves as well
Commits on Oct 13, 2011
  1. Merge branch 'master' into mask

    gnarf committed Oct 13, 2011
  2. Timepicker: Quick updates from code review.

    gnarf committed Oct 13, 2011
    * Remove docs link.
    * remove button from depends
    * move destroy method under _create - make _destroy
    * comment in _trimValue describing purpose
    * _trimValue becomes _adjustValue
    * don't set the ampm option from culture dependency
    * reordering methods
    * rsingleh / rlowerhg (rename)
Commits on Oct 25, 2011
  1. Merge branch 'master' into mask

    gnarf committed Oct 25, 2011
Commits on Oct 26, 2011
  1. Timepicker: value method

    gnarf committed Oct 26, 2011
Commits on Oct 27, 2011
Commits on Oct 28, 2011
Commits on Nov 18, 2011
Commits on Nov 24, 2011
  1. Upgrade jQuery to 1.7.1.

    jzaefferer committed Nov 24, 2011
Commits on Mar 14, 2012
Commits on Aug 3, 2012
  1. Merge branch 'master' into mask

    gnarf committed Aug 3, 2012
Commits on Aug 7, 2012
Commits on Sep 4, 2012
  1. Merge branch 'master' into mask

    gnarf committed Sep 4, 2012
  2. Merge branch 'master' into mask

    gnarf committed Sep 4, 2012
Commits on Oct 15, 2012
  1. Merge remote-tracking branch 'origin/master' into mask

    Zach Shepherd committed Oct 15, 2012
    Conflicts:
    	demos/index.html
  2. mask/timepicker: use jquery files from tests directory, which actuall…

    Zach Shepherd committed Oct 15, 2012
    …y exist
  3. mask: update demos following merge

    Zach Shepherd committed Oct 15, 2012
  4. Mask: fix bug in visual test case

    Zach Shepherd committed Oct 15, 2012
  5. Mask: add visual display of field's value and validity in visual test…

    Zach Shepherd committed Oct 15, 2012
    … case
  6. Mask: fix isValid logic; previously, any call to getValue(true) resul…

    Zach Shepherd committed Oct 15, 2012
    …ted in isValid being set to true
  7. Mask: add visual test for removing an invalid value on blur

    Zach Shepherd committed Oct 15, 2012
    This change adds a test for the functionality to remove an invalid value on blur as described in section 3 of http://wiki.jqueryui.com/w/page/12137996/Mask:
        Removing an incomplete value can be done by binding to the regular blur event, checking !mask("valid"), then using .val("") to clear the input.