Dialog http://bugs.jqueryui.com/ticket/5388 #510

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@Akkuma
Akkuma commented Oct 31, 2011

Dialog: Modified how finding the max z-index was done, should improve performance as well. Prevented dialogs from infinitely increasing z-index. Fixed #5388 - Dialog: Don't change z-index when already at the top

Originally dialog looked for all dialogs through the css class. Rather than take that performance hit, I'm just storing the instance of the dialog created in a tracking object, based on the titleId. From this collection we can easily determine the maximum z-index that should be applied to any dialog.

Akkuma added some commits Oct 31, 2011
@Akkuma Akkuma Dialog: Modified how finding the max z-index was done, should improve…
… performance as well. Prevented dialogs from infinitely increasing z-index. Fixed #5388 - Dialog: Don't change z-index when already at the top
b2eda4d
@Akkuma Akkuma Changes made per @scottgonzalez 's suggestions. Storing titleId as a …
…property on the dialog instance, storing the instance rather than select data, changed tests to use local variables, and moved updateMaxZ into dialog prototype.
b15c419
@Akkuma Akkuma Really moved updateMaxZ into dialog prototype this time. e2bebd4
@jzaefferer jzaefferer referenced this pull request Oct 23, 2012
Merged

Dialog Redesign #787

@jzaefferer
Member

Don't need this anymore since 3829a37 landed.

@jzaefferer jzaefferer closed this Oct 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment