Button: support <input> tag wrapped in <label> tag. Fix #6063, Button doesn't support radio input inside label. #531

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@mail6543210

No description provided.

mail6543210 added some commits Nov 22, 2011

Button: support <input> wrapped in <label>
Signed-off-by: mail6543210 <mail6543210@yahoo.com.tw>
@mail6543210

This comment has been minimized.

Show comment Hide comment
@mail6543210

mail6543210 Nov 22, 2011

Actually I'm not really sure how does the unit-test work, I just guess and edit the button.html.
If my guess is correct, please also let mo know.
Thanks.

Actually I'm not really sure how does the unit-test work, I just guess and edit the button.html.
If my guess is correct, please also let mo know.
Thanks.

@fajan

This comment has been minimized.

Show comment Hide comment
@fajan

fajan Oct 19, 2012

I did some other approach for the same bug: I just updated the _determineButtonType to check for parents, and if matched just temporary detached the input from DOM. #777

And for unit test: I don't know either, but just after a quick look: maybe it requires a '#6063' test case in https://github.com/jquery/jquery-ui/blob/master/tests/unit/button/button_tickets.js too?

fajan commented Oct 19, 2012

I did some other approach for the same bug: I just updated the _determineButtonType to check for parents, and if matched just temporary detached the input from DOM. #777

And for unit test: I don't know either, but just after a quick look: maybe it requires a '#6063' test case in https://github.com/jquery/jquery-ui/blob/master/tests/unit/button/button_tickets.js too?

@mikesherov

This comment has been minimized.

Show comment Hide comment
@mikesherov

mikesherov Nov 10, 2012

Member

Thanks for the patch, but reviewing the underlying ticket we closed it as wontfix, see @jzaefferer's comment there: http://bugs.jqueryui.com/ticket/6063#comment:13

Member

mikesherov commented Nov 10, 2012

Thanks for the patch, but reviewing the underlying ticket we closed it as wontfix, see @jzaefferer's comment there: http://bugs.jqueryui.com/ticket/6063#comment:13

@mikesherov mikesherov closed this Nov 10, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment