Datepicker: fixed #5679 #543

Closed
wants to merge 2 commits into from

2 participants

@bardt

Fixed the bug prevented me to reinitialize the datepicker. It could be a problem then using datepicker in web-apps that re-render the screen often. Also prevented multiple event bind on initialize.

Roman Salnikov added some commits Nov 29, 2011
Roman Salnikov Datepicker: added a condition to reinitialize datepicker if there is …
…no mainDiv on the page. Fixed #5679 - Datepicker should reinitialize if dpDiv is removed
c0bd1c3
Roman Salnikov Datepicker: added a condition to reinitialize datepicker if there is …
…no mainDiv on the page. Fixed #5679 - Datepicker should reinitialize if dpDiv is removed
f20486d
@ryanflorence ryanflorence referenced this pull request in turbolinks/turbolinks-classic Oct 19, 2012
Closed

jQuery UI tips and tricks #76

@mikesherov
jQuery Foundation member

@bardt, I know it's been a while, but can you rebase this pull request and create a unit test supporting this change? I'd like to land it! Thanks!

@bardt
@mikesherov
jQuery Foundation member

@bardt, yes, you should create a new pull request, seeing as you created this pull request out of master, which is not ideal. You should be using a topic branch: http://git-scm.com/book/en/Git-Branching-Branching-Workflows so that you can merge and rebase if you have to. A rebase is essentially a merge, but it places your commits at the end instead of in the middle: http://git-scm.com/book/en/Git-Branching-Rebasing

When you submit your new pull request, please make sure the changes pass unit tests in all of our supported browsers, and that your new unit tests cover the issue. See here for more info: http://wiki.jqueryui.com/w/page/12137724/Bug-Fixing-Guide

Considering you're creating a new pull request, I'm going to close this one. Thanks again!

@mikesherov mikesherov closed this Nov 13, 2012
@bardt

@mikesherov New pull request is here: #826
All tests are included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment