Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Droppable: Fixes: Ticket #8060. Over event is not fired correctly in a droppable. #583

Closed
wants to merge 1 commit into from

2 participants

Nicolás Hatcher Andrés Mike Sherov
Nicolás Hatcher Andrés

jquiery.ui.droppable

this.over should change in a drop event even if the draggable is not accepted.

Mike Sherov
Collaborator

Hi @nhatcher, thanks again for contributing this patch. We recently re-enabled the test suite for droppable. In order for us to land this patch, we'd need a few tests added to the test suite proving this doesn't break existing functionality and also that it fixes the bug as described. Can you add some tests here please?

Mike Sherov
Collaborator

@nhatcher, have you had a chance to look into adding tests for this pull request?

Mike Sherov
Collaborator

Thanks again for contributing! Actually, this works as expected per the documentation. From http://api.jqueryui.com/droppable/#event-over: "Triggered when an accepted draggable is dragged over the droppable (based on the tolerance option)." For that reason, I'm going to close this.

Just because this didn't get merged, that doesn't mean you shouldn't try contributing another patch! There's tons of open bugs to work on over at: http://bugs.jqueryui.com/query?status=open&type=bug&group=component&col=id&col=summary&col=status&col=type&col=priority&col=milestone&col=component&order=priority&report=31

Thanks again!

Mike Sherov mikesherov closed this November 19, 2012
Nicolás Hatcher Andrés

Hi @mikesherov, thank you very much for taking your time in reviewing the pull request and the encouragement. Unfortunately, I will not have a chance until the end of the year to have a look at this issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jan 26, 2012
Nicolás Hatcher Andrés Droppable: this.over is changed even for non acceptable draggables. F…
…ixes Ticket #8060. Over was not fired correctly.
1636830
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 3 additions and 2 deletions. Show diff stats Hide diff stats

  1. 5  ui/jquery.ui.droppable.js
5  ui/jquery.ui.droppable.js
@@ -226,9 +226,10 @@ $.ui.ddmanager = {
226 226
 			if (!this.options.disabled && this.visible && $.ui.intersect(draggable, this, this.options.tolerance))
227 227
 				dropped = this._drop.call(this, event) || dropped;
228 228
 
229  
-			if (!this.options.disabled && this.visible && this.accept.call(this.element[0],(draggable.currentItem || draggable.element))) {
  229
+			if (!this.options.disabled && this.visible) {
230 230
 				this.isout = 1; this.isover = 0;
231  
-				this._deactivate.call(this, event);
  231
+				if (this.accept.call(this.element[0],(draggable.currentItem || draggable.element)))
  232
+					this._deactivate.call(this, event);
232 233
 			}
233 234
 
234 235
 		});
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.