Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: Removed the timeout for the change event. Fixes #7550 #596

Closed

Conversation

scottgonzalez
Copy link
Member

This is a duplicate of PR 508, but rebased and squashed.

I'd like at least one other person to review this before we land it, just to make sure I didn't miss any scenarios.

… Autocomplete change event not triggered in time.

Thanks spekary for finding a workaround for IE.
@scottgonzalez
Copy link
Member Author

@spekary I did some manual testing in Chrome and IE and I'm getting the change event before the form's submit event now. Can you confirm?

@kborchers
Copy link
Member

This looks good in my tests as well. Everything seems to be functioning correctly, including the test in the bug report. I may not have thought of every scenario but all of the demos seem fine and playing around with forms and submitting and making sure events fire in the correct order all seem good to me.

@spekary
Copy link
Contributor

spekary commented Feb 14, 2012

Looks good here too. Tested on Mac Safari, Mac Netscape, IE 7 in Win XP, IE 9 in Win7. Checked both this problem and the other problem I mentioned regarding canceling the menu when you tab out during an async lookup. Was concerned that you took out cancelSearch = true in the blur, but since its closing immediately now, its all good. Looking forward to getting it stable.

@scottgonzalez
Copy link
Member Author

Landed in f5b52a8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants