Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Slider: when handles overlap clicking and dragging will select the right one ... #659

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
Contributor

jpka commented May 17, 2012

... by deferring choice until dragging. Fixed #3467 - Sliders Handles can overlap, only small sliver of slider is selectable

@jpka jpka Slider: when handles overlap clicking and dragging will select the ri…
…ght one by deferring choice until dragging. Fixed #3467 - Sliders Handles can overlap, only small sliver of slider is selectable
7c97b93
Contributor

jpka commented Jun 13, 2012

any comments on this? I'm a newbie to contributing to open source so please let me know if there is an issue.

Member

mikesherov commented Nov 11, 2012

@jpka, I know it's been a while, and thanks for contributing, but you possibly rebase this pull request and also provide some unit tests in support of this change. That's what would be required at minimum to get this to be accepted. Thanks! Let me know if you have any questions!

Owner

scottgonzalez commented Nov 12, 2012

@toddparker Do you remember the site we found that had a good solution for this? I think it was just shuffling z-index.

Google is failing me here. The Dojo example pushes the sliders when they collide:
http://dojotoolkit.org/reference-guide/1.8/dojox/form/RangeSlider.html#

I think the example we found let them overlap and had the last handle that moved be on top so that would drag back out when stacked.

@petersendidit - Thank you, that was exactly the demo I was looking for. I think that behavior feels about right.

Owner

scottgonzalez commented Nov 13, 2012

Yup, that's the one. @jpka I think shuffling the z-index is a lot simpler and would be a better fix. Would you be interested in implementing that instead?

Contributor

jpka commented Nov 13, 2012

I didn't thought of that, it is simpler indeed. I'll do it tonight.

Owner

scottgonzalez commented Nov 13, 2012

Thanks @jpka. I'll close this PR in favor of the forthcoming z-index change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment